fix: remove primary icon #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 775 775
Lines 15979 15979
Branches 2059 2059
=======================================
Hits 13616 13616
Misses 2329 2329
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
projects/components/src/breadcrumbs/breadcrumbs.component.test.ts
Outdated
Show resolved
Hide resolved
added 2 commits
February 25, 2021 19:35
projects/components/src/breadcrumbs/breadcrumbs.component.test.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Feb 26, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the double icons present in the breadcrumbs and the header, particularly in ht-page-header also to show or not the icons in the crumbs following the first crumb.
Testing
Visual verification
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.